WIP: feat: visual selection annotations #127

Draft

noe.trevino wants to merge 13 commits from feature-108/visual-selection-annotations into nightly

pull from: feature-108/visual-selection-annotations

merge into: noe.trevino:nightly

noe.trevino:main

noe.trevino:feature-108/range-docs

noe.trevino:feature-108/range-outputs

noe.trevino:feature-108/range-display

noe.trevino:feature-108/nesting-rules

noe.trevino:feature-108/render-helper

noe.trevino:nightly

noe.trevino:release-please--branches--main

noe.trevino:fix-docs-forgejo-migration

noe.trevino:bugfix-107/telescope-picker-opts

noe.trevino:ci/fix-auto-assign-forgejo

noe.trevino:feat-105/fs-watcher-on-bm-file

noe.trevino:bugfix-99/quickfix-usees-extmark-bookmarks

Conversation 0 Commits 13 Files changed 10 +477 -29

noe.trevino commented 2026-10-13 12:57:19 -05:00

Owner

Copy link

Umbrella PR for range annotations. Each step lands here as its own stacked PR.

• store and track ranges; annotate from Visual mode and :'<,'>HauntAnnotate
• fold the six sign/annotation render sites into one render/clear pair
• find a range from any line inside it (delete, toggle, edit)
• draw ranges (rail by default, range.style config)
• range-aware outputs: quickfix end_lnum, picker labels, sidekick :L45-L48
• docs

Companion change outside this repo: haunt-cli needs an EndLine field so it stops stripping ranges.

Refs #108

Umbrella PR for range annotations. Each step lands here as its own stacked PR. - [ ] store and track ranges; annotate from Visual mode and `:'<,'>HauntAnnotate` - [ ] fold the six sign/annotation render sites into one render/clear pair - [ ] find a range from any line inside it (delete, toggle, edit) - [ ] draw ranges (rail by default, `range.style` config) - [ ] range-aware outputs: quickfix `end_lnum`, picker labels, sidekick `:L45-L48` - [ ] docs Companion change outside this repo: `haunt-cli` needs an `EndLine` field so it stops stripping ranges. Refs #108

noe.trevino added 1 commit 2026-10-13 12:57:19 -05:00

chore: start #108 visual selection annotations ... b5ed491e59

Refs #108

noe.trevino referenced this pull request 2026-10-13 12:57:25 -05:00

feat: save visual selections as range annotations #128

noe.trevino referenced this pull request 2026-10-13 14:38:20 -05:00

feature: support visual selection annotations #108

noe.trevino referenced this pull request 2026-10-13 15:08:21 -05:00

refactor: one render/clear pair for bookmark visuals #129

noe.trevino referenced this pull request 2026-10-13 15:28:11 -05:00

feat: nesting rules for range annotations #130

noe.trevino referenced this pull request 2026-10-13 17:50:32 -05:00

feat: draw a rail down range annotations #131

noe.trevino added 12 commits 2026-10-13 18:23:43 -05:00

feat(persistence): store an optional end_line for range bookmarks ... e0c865aba0

- add an end_line param to create_bookmark
- add an end_line field to the Bookmark object
- reject an end_line before line in is_valid_bookmark
- only serialize end_line for ranges

Refs #108

feat(display): track range bookmarks with a ranged extmark ... 6c9cef3d83

- end range extmarks at col 0 of the line after the range
- add get_extmark_range to read the range back
- clamp the end so it never falls before the start

Refs #108

feat(store): sync end_line from the tracking extmark ... 303ae8b412

- read each bookmark's range from its extmark on sync
- tests: undoing a whole-range delete brings the range back

Refs #108

feat(api): let annotate() take a line range ... 6cb62db5f8

- add an optional range param to annotate
- order and clamp the range to the buffer
- pass end_line through to create_bookmark

Refs #108

feat(api): annotate the Visual selection ... 80aa10f4c1

- take the range from the Visual selection (v, V, CTRL-V)
- leave Visual mode before prompting
- tests: drive Visual mode through a <Plug> mapping

Refs #108

feat(commands): accept a range on :HauntAnnotate ... 4b5ac2a5a1

- add range to the HauntAnnotate command
- pass line1/line2 through to annotate

Refs #108

refactor(display): report no end for a one-line extmark range ... 82455dcf63

- return a nil end from get_extmark_range when the end is not past the start
- read get_extmark_line through get_extmark_range
- store the synced end as-is

Refs #108

refactor(persistence): normalize end_line where bookmarks enter ... e749c8cf4c

- add normalize_end_line as the one "is a range" rule
- normalize end_line in create_bookmark and on load
- test end_line ~= nil in set_bookmark_mark and _build_serializable

Refs #108

fix(api): reject an annotate range past the end of the buffer ... 7004217387

- add normalize_range to order and clamp a line range in one place
- reject a range whose start is past the last line with an error notify
- return the raw selection ends from take_visual_range

Refs #108

refactor(commands): pass text and range from one branch ... d241b0cd4a

- compute the command text and range once for has_args commands

Refs #108

test: use the shared helpers in the range specs ... 79030be3d0

- read the saved file with helpers.read_bookmarks_file in api_spec
- build and clean up the range sync buffer with helpers in store_spec

Refs #108

Merge pull request 'feat: save visual selections as range annotations' (#128) from feature-108/range-persistence into feature-108/visual-selection-annotations ... 7b593d08b6

Reviewed-on: #128

noe.trevino referenced this pull request 2026-10-13 18:58:26 -05:00

feat: range-aware outputs #132

noe.trevino referenced this pull request 2026-10-13 19:03:48 -05:00

docs: range annotations #133

All checks were successful

Hide all checks

CI / Check for debug messages (pull_request) Successful in 3s

Details

CI / config (pull_request) Successful in 4s

Details

CI / stylua (pull_request) Successful in 5s

Details

CI / tests (pull_request) Successful in 14s

Details

CI / docs (pull_request) Has been skipped

Details

CI / release (pull_request) Has been skipped

Details

CI / ci (pull_request) Successful in 0s

Details

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature-108/visual-selection-annotations:feature-108/visual-selection-annotations

git switch feature-108/visual-selection-annotations

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch nightly

git merge --no-ff feature-108/visual-selection-annotations

git switch feature-108/visual-selection-annotations

git rebase nightly

git switch nightly

git merge --ff-only feature-108/visual-selection-annotations

git switch feature-108/visual-selection-annotations

git rebase nightly

git switch nightly

git merge --no-ff feature-108/visual-selection-annotations

git switch nightly

git merge --squash feature-108/visual-selection-annotations

git switch nightly

git merge --ff-only feature-108/visual-selection-annotations

git switch nightly

git merge feature-108/visual-selection-annotations

git push origin nightly

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

autorelease: pending

  

autorelease: tagged

  

bug

Something isn't working

  

ci/cd

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

improvement

  

invalid

This doesn't seem right

  

priority

high

Priority, carried over from the GitHub project board

  

priority

low

Priority, carried over from the GitHub project board

  

question

Further information is requested

  

refactor

  

size

L

  

size

M

Size, carried over from the GitHub project board

  

size

S

Size, carried over from the GitHub project board

  

size

XS

Size, carried over from the GitHub project board

  

wontfix

This will not be worked on

No labels

autorelease: pending

autorelease: tagged

bug

ci/cd

documentation

duplicate

enhancement

good first issue

help wanted

improvement

invalid

priority

high

priority

low

question

refactor

size

L

size

M

size

S

size

XS

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

noe.trevino/haunt.nvim!127

No description provided.