feat: save visual selections as range annotations #128

Merged

noe.trevino merged 11 commits from feature-108/range-persistence into feature-108/visual-selection-annotations 2026-10-13 18:23:43 -05:00

Conversation 3 Commits 11 Files changed 10 +477 -29

noe.trevino commented 2026-10-13 12:57:25 -05:00

Owner

Copy link

Stacked on #127.

• store an optional end_line on bookmarks (storage stays v2)
• track the range with one ranged extmark; the end anchors at col 0 of the next line
• sync end_line from the extmark on every read
• annotate(text, { line1, line2 })
• annotate the Visual selection (v, V, CTRL-V)
• :'<,'>HauntAnnotate
• tests: undoing a whole-range delete brings the range back; Visual mode driven through a <Plug> mapping

Cleanup from review:

• one "is a range" rule (normalize_end_line), applied where bookmarks enter
• a range starting past the end of the buffer gets a clear error
• get_extmark_line reuses get_extmark_range
• specs use the shared helpers

Not in this PR: drawing ranges differently, and finding a range from lines inside it.

• tests pass (565)

Refs #108

Stacked on #127. - store an optional `end_line` on bookmarks (storage stays v2) - track the range with one ranged extmark; the end anchors at col 0 of the next line - sync `end_line` from the extmark on every read - `annotate(text, { line1, line2 })` - annotate the Visual selection (v, V, CTRL-V) - `:'<,'>HauntAnnotate` - tests: undoing a whole-range delete brings the range back; Visual mode driven through a `<Plug>` mapping Cleanup from review: - one "is a range" rule (`normalize_end_line`), applied where bookmarks enter - a range starting past the end of the buffer gets a clear error - `get_extmark_line` reuses `get_extmark_range` - specs use the shared helpers Not in this PR: drawing ranges differently, and finding a range from lines inside it. - [x] tests pass (565) Refs #108

noe.trevino added 6 commits 2026-10-13 12:57:25 -05:00

feat(persistence): store an optional end_line for range bookmarks ... e0c865aba0

- add an end_line param to create_bookmark
- add an end_line field to the Bookmark object
- reject an end_line before line in is_valid_bookmark
- only serialize end_line for ranges

Refs #108

feat(display): track range bookmarks with a ranged extmark ... 6c9cef3d83

- end range extmarks at col 0 of the line after the range
- add get_extmark_range to read the range back
- clamp the end so it never falls before the start

Refs #108

feat(store): sync end_line from the tracking extmark ... 303ae8b412

- read each bookmark's range from its extmark on sync
- tests: undoing a whole-range delete brings the range back

Refs #108

feat(api): let annotate() take a line range ... 6cb62db5f8

- add an optional range param to annotate
- order and clamp the range to the buffer
- pass end_line through to create_bookmark

Refs #108

feat(api): annotate the Visual selection ... 80aa10f4c1

- take the range from the Visual selection (v, V, CTRL-V)
- leave Visual mode before prompting
- tests: drive Visual mode through a <Plug> mapping

Refs #108

feat(commands): accept a range on :HauntAnnotate ... 4b5ac2a5a1

- add range to the HauntAnnotate command
- pass line1/line2 through to annotate

Refs #108

noe.trevino referenced this pull request 2026-10-13 15:08:21 -05:00

refactor: one render/clear pair for bookmark visuals #129

noe.trevino referenced this pull request 2026-10-13 15:28:11 -05:00

feat: nesting rules for range annotations #130

noe.trevino added 5 commits 2026-10-13 17:34:34 -05:00

refactor(display): report no end for a one-line extmark range ... 82455dcf63

- return a nil end from get_extmark_range when the end is not past the start
- read get_extmark_line through get_extmark_range
- store the synced end as-is

Refs #108

refactor(persistence): normalize end_line where bookmarks enter ... e749c8cf4c

- add normalize_end_line as the one "is a range" rule
- normalize end_line in create_bookmark and on load
- test end_line ~= nil in set_bookmark_mark and _build_serializable

Refs #108

fix(api): reject an annotate range past the end of the buffer ... 7004217387

- add normalize_range to order and clamp a line range in one place
- reject a range whose start is past the last line with an error notify
- return the raw selection ends from take_visual_range

Refs #108

refactor(commands): pass text and range from one branch ... d241b0cd4a

- compute the command text and range once for has_args commands

Refs #108

test: use the shared helpers in the range specs ... 79030be3d0

- read the saved file with helpers.read_bookmarks_file in api_spec
- build and clean up the range sync buffer with helpers in store_spec

Refs #108

noe.trevino commented 2026-10-13 18:16:12 -05:00

Author

Owner

Copy link

@smith this is a test. say hi

@smith this is a test. say hi

noe.trevino commented 2026-10-13 18:19:56 -05:00

Author

Owner

Copy link

@smith test again, say hello

@smith test again, say hello

👀 1

smith commented 2026-10-13 18:20:14 -05:00

Collaborator

Copy link

Good evening, Mr. Trevino.

Hello. Your message arrived intact, and so did the one before it. I changed no files.

_Run

Good evening, Mr. Trevino. Hello. Your message arrived intact, and so did the one before it. I changed no files. _{[Run](https://git.thenoetrevino.com/noe.trevino/ci/actions/runs/41)}

noe.trevino merged commit 7b593d08b6 into feature-108/visual-selection-annotations 2026-10-13 18:23:43 -05:00

noe.trevino referenced this pull request from a commit 2026-10-13 18:23:43 -05:00

Merge pull request 'feat: save visual selections as range annotations' (#128) from feature-108/range-persistence into feature-108/visual-selection-annotations

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

autorelease: pending

  

autorelease: tagged

  

bug

Something isn't working

  

ci/cd

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

improvement

  

invalid

This doesn't seem right

  

priority

high

Priority, carried over from the GitHub project board

  

priority

low

Priority, carried over from the GitHub project board

  

question

Further information is requested

  

refactor

  

size

L

  

size

M

Size, carried over from the GitHub project board

  

size

S

Size, carried over from the GitHub project board

  

size

XS

Size, carried over from the GitHub project board

  

wontfix

This will not be worked on

No labels

autorelease: pending

autorelease: tagged

bug

ci/cd

documentation

duplicate

enhancement

good first issue

help wanted

improvement

invalid

priority

high

priority

low

question

refactor

size

L

size

M

size

S

size

XS

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

noe.trevino/haunt.nvim!128

No description provided.