feat: range-aware outputs #132

Open
noe.trevino wants to merge 5 commits from feature-108/range-outputs into feature-108/range-display
Owner

Stacked on #131. Retarget to the umbrella (#127) once the ones below merge.

  • quickfix sets end_lnum on ranges
  • pickers label ranges path:45–48; snacks/telescope preview the whole range
  • fzf keeps path:line:col and adds an L45–48 token
  • sidekick writes :L45-L48 (sidekick's own range format)
  • yank_locations follows sidekick, so ranges yank as :L45-L48
  • hooks carry end_line; update also gets old_end_line/new_end_line

Calls to look at:

  • no plain path:45-48 yank; it would mix formats with the sidekick one

  • telescope and fzf are tested with mocks only (not installed here)

  • update hook's end_line and new_end_line are the same value

  • range + single spec for each output

  • tests pass (672)

  • retarget to the umbrella after #128–#131

Refs #108

Stacked on #131. Retarget to the umbrella (#127) once the ones below merge. - quickfix sets `end_lnum` on ranges - pickers label ranges `path:45–48`; snacks/telescope preview the whole range - fzf keeps `path:line:col` and adds an `L45–48` token - sidekick writes `:L45-L48` (sidekick's own range format) - `yank_locations` follows sidekick, so ranges yank as `:L45-L48` - hooks carry `end_line`; update also gets `old_end_line`/`new_end_line` Calls to look at: - no plain `path:45-48` yank; it would mix formats with the sidekick one - telescope and fzf are tested with mocks only (not installed here) - update hook's `end_line` and `new_end_line` are the same value - [x] range + single spec for each output - [x] tests pass (672) - [ ] retarget to the umbrella after #128–#131 Refs #108
- set end_lnum on range entries

Refs #108
- label ranges as path:45–48 in snacks and telescope
- fzf adds an L45–48 token after path:line:col
- snacks end_pos and telescope lnend span the range

Refs #108
- ranges get sidekick's own :L45-L48 form

Refs #108
- tests: yank shares the sidekick :L45-L48 form

Refs #108
feat(hooks): carry end_line in bookmark hook payloads
All checks were successful
Auto Assign / assign (pull_request_target) Successful in 1s
CI / stylua (pull_request) Successful in 5s
CI / config (pull_request) Successful in 5s
CI / Check for debug messages (pull_request) Successful in 5s
CI / tests (pull_request) Successful in 17s
CI / docs (pull_request) Has been skipped
CI / release (pull_request) Has been skipped
CI / ci (pull_request) Successful in 0s
95e7210b6e
- create, delete, toggle and navigation add end_line
- update adds end_line, old_end_line and new_end_line

Refs #108
All checks were successful
Auto Assign / assign (pull_request_target) Successful in 1s
CI / stylua (pull_request) Successful in 5s
CI / config (pull_request) Successful in 5s
CI / Check for debug messages (pull_request) Successful in 5s
CI / tests (pull_request) Successful in 17s
CI / docs (pull_request) Has been skipped
CI / release (pull_request) Has been skipped
CI / ci (pull_request) Successful in 0s
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature-108/range-outputs:feature-108/range-outputs
git switch feature-108/range-outputs

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch feature-108/range-display
git merge --no-ff feature-108/range-outputs
git switch feature-108/range-outputs
git rebase feature-108/range-display
git switch feature-108/range-display
git merge --ff-only feature-108/range-outputs
git switch feature-108/range-outputs
git rebase feature-108/range-display
git switch feature-108/range-display
git merge --no-ff feature-108/range-outputs
git switch feature-108/range-display
git merge --squash feature-108/range-outputs
git switch feature-108/range-display
git merge --ff-only feature-108/range-outputs
git switch feature-108/range-display
git merge feature-108/range-outputs
git push origin feature-108/range-display
Sign in to join this conversation.
No description provided.