Refactor 108/go 1.26 upgrade #109

noe.trevino · 2026-02-18T13:11:51-06:00

noe.trevino commented

2026-02-18 13:11:51 -06:00

Checklist

Read CONTRIBUTING.md
Ran tests (go test ./... -race) locally
Formatted and linted with gofmt -w . and golangci-lint run ./... respectively
Added tests if necessary (significant changes/complex logic)
Updated documentation if applicable
Updated README.md if applicable

Summary

Closes: #108

## Checklist - [x] Read `CONTRIBUTING.md` - [x] Ran tests (`go test ./... -race`) locally - [x] Formatted and linted with `gofmt -w .` and `golangci-lint run ./...` respectively - [x] Added tests if necessary (significant changes/complex logic) - [x] Updated documentation if applicable - [x] Updated `README.md` if applicable ## Summary  Closes: #108

claude[bot] (Migrated from github.com) reviewed

2026-02-18 13:15:08 -06:00

internal/converters/column_test.go

					
				@ -606,11 +606,6 @@ func TestColumnsFromRowsToModels(t *testing.T) {

					}

				}

The intPtr function is annotated //go:fix inline but is not deleted — unlike the equivalent helpers (stringPtr, ptrStr, ptrTime, etc.) removed from other files. If intPtr is still called anywhere in this file (e.g. inside intPtrEqual), the new CI step (go fix ./... + git diff --exit-code) will inline those remaining call sites, produce a non-empty diff, and break CI. Either fully inline all remaining intPtr call sites and delete the function, or remove //go:fix inline until the function is ready to be fully eliminated.

The `intPtr` function is annotated `//go:fix inline` but is not deleted — unlike the equivalent helpers (`stringPtr`, `ptrStr`, `ptrTime`, etc.) removed from other files. If `intPtr` is still called anywhere in this file (e.g. inside `intPtrEqual`), the new CI step (`go fix ./...` + `git diff --exit-code`) will inline those remaining call sites, produce a non-empty diff, and break CI. Either fully inline all remaining `intPtr` call sites and delete the function, or remove `//go:fix inline` until the function is ready to be fully eliminated.

Sign in to join this conversation.

No reviewers