Feature 151/task view multilines #154

noe.trevino · 2026-06-23T13:09:52-05:00

noe.trevino commented

2026-06-23 13:09:52 -05:00

Checklist

Read CONTRIBUTING.md
Ran tests (go test ./... -race) locally
Formatted and linted with gofmt -w . and golangci-lint run ./... respectively
Added tests if necessary (significant changes/complex logic)
Updated documentation if applicable
Updated README.md if applicable

Summary

## Checklist - [x] Read `CONTRIBUTING.md` - [x] Ran tests (`go test ./... -race`) locally - [x] Formatted and linted with `gofmt -w .` and `golangci-lint run ./...` respectively - [x] Added tests if necessary (significant changes/complex logic) - [x] Updated documentation if applicable - [x] Updated `README.md` if applicable ## Summary

claude[bot] (Migrated from github.com) reviewed

2026-06-23 13:21:24 -05:00

internal/cli/task/task_helpers.go

len(m) returns the byte length of the match, not the terminal column width. For the • marker (U+2022), len("• ") is 4 (3 UTF-8 bytes + 1 space) but its visual width is 2 columns. This means:

hang becomes 4 spaces instead of 2 — continuation lines are indented 2 columns past where the bullet text actually starts.
limit - len(hang) narrows the wrap budget by 4 columns instead of 2 — lines wrap unnecessarily early.

• is explicitly documented as a supported marker in SKILL.md (line ~184), so this is a guaranteed rendering defect for any wrapped bullet item using that character.

Fix: use uniseg.StringWidth (or xansi's own width helper if one is exposed) to measure m in terminal columns instead of bytes.

`len(m)` returns the **byte** length of the match, not the terminal column width. For the `•` marker (U+2022), `len("• ")` is 4 (3 UTF-8 bytes + 1 space) but its visual width is 2 columns. This means: 1. `hang` becomes 4 spaces instead of 2 — continuation lines are indented 2 columns past where the bullet text actually starts. 2. `limit - len(hang)` narrows the wrap budget by 4 columns instead of 2 — lines wrap unnecessarily early. `•` is explicitly documented as a supported marker in SKILL.md (line ~184), so this is a guaranteed rendering defect for any wrapped bullet item using that character. Fix: use [`uniseg.StringWidth`](https://pkg.go.dev/github.com/rivo/uniseg#StringWidth) (or `xansi`'s own width helper if one is exposed) to measure `m` in terminal columns instead of bytes.

claude[bot] (Migrated from github.com) reviewed

2026-06-23 13:21:26 -05:00

internal/cli/task/task_helpers.go

					
				@ -11,0 +13,4 @@

				// be hang-indented under the marker's text. Covers "- ", "* ", "• ", checkbox

				// "[ ] "/"[x] ", and numbered "1. "/"1) " markers, with optional leading

				// whitespace.

				var listMarkerRe = regexp.MustCompile(`^(\s*(?:[-*•]|\[.?\]|\d+[.)])\s+)`)

The outer group is a capturing group (…) but the only call site uses FindString, which returns the full match and ignores sub-captures. The group should be non-capturing to avoid an unnecessary tracking allocation.

var listMarkerRe = regexp.MustCompile(`^(?:\s*(?:[-*•]|\[.?\]|\d+[.)])\s+)`)

The outer group is a capturing group `(…)` but the only call site uses `FindString`, which returns the full match and ignores sub-captures. The group should be non-capturing to avoid an unnecessary tracking allocation. ```suggestion var listMarkerRe = regexp.MustCompile(`^(?:\s*(?:[-*•]|\[.?\]|\d+[.)])\s+)`) ```

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature-151/task-view-multilines:feature-151/task-view-multilines

git switch feature-151/task-view-multilines

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff feature-151/task-view-multilines

git switch feature-151/task-view-multilines

git rebase main

git switch main

git merge --ff-only feature-151/task-view-multilines

git switch feature-151/task-view-multilines

git rebase main

git switch main

git merge --no-ff feature-151/task-view-multilines

git switch main

git merge --squash feature-151/task-view-multilines