Feature 132/concurrent task detail #134

noe.trevino · 2026-02-23T20:36:36-06:00

noe.trevino commented

2026-02-23 20:36:36 -06:00

Checklist

Read CONTRIBUTING.md
Ran tests (go test ./... -race) locally
Formatted and linted with gofmt -w . and golangci-lint run ./... respectively
Added tests if necessary (significant changes/complex logic)
Updated documentation if applicable
Updated README.md if applicable

Summary

#132

## Checklist - [x] Read `CONTRIBUTING.md` - [x] Ran tests (`go test ./... -race`) locally - [x] Formatted and linted with `gofmt -w .` and `golangci-lint run ./...` respectively - [x] Added tests if necessary (significant changes/complex logic) - [x] Updated documentation if applicable - [x] Updated `README.md` if applicable ## Summary  #132

noe.trevino commented

2026-02-23 20:37:29 -06:00

BenchmarkGetTaskDetail/Sequential-6         	    3601	    325552 ns/op	    9112 B/op	     254 allocs/op
BenchmarkGetTaskDetail/Sequential-6         	    3553	    325619 ns/op	    9112 B/op	     254 allocs/op
BenchmarkGetTaskDetail/Sequential-6         	    3678	    327331 ns/op	    9112 B/op	     254 allocs/op
BenchmarkGetTaskDetail/Sequential-6         	    3693	    324654 ns/op	    9112 B/op	     254 allocs/op
BenchmarkGetTaskDetail/Concurrent-6         	    5094	    213430 ns/op	   13860 B/op	     328 allocs/op
BenchmarkGetTaskDetail/Concurrent-6         	    5576	    212538 ns/op	   13847 B/op	     328 allocs/op
BenchmarkGetTaskDetail/Concurrent-6         	    5515	    218339 ns/op	   13843 B/op	     328 allocs/op
BenchmarkGetTaskDetail/Concurrent-6         	    5722	    215569 ns/op	   13845 B/op	     328 allocs/op
BenchmarkGetTaskDetail/Concurrent-6         	    5580	    213162 ns/op	   13843 B/op	     328 allocs/op

```BenchmarkGetTaskDetail/Sequential-6 3640 325121 ns/op 9112 B/op 254 allocs/op BenchmarkGetTaskDetail/Sequential-6 3601 325552 ns/op 9112 B/op 254 allocs/op BenchmarkGetTaskDetail/Sequential-6 3553 325619 ns/op 9112 B/op 254 allocs/op BenchmarkGetTaskDetail/Sequential-6 3678 327331 ns/op 9112 B/op 254 allocs/op BenchmarkGetTaskDetail/Sequential-6 3693 324654 ns/op 9112 B/op 254 allocs/op BenchmarkGetTaskDetail/Concurrent-6 5094 213430 ns/op 13860 B/op 328 allocs/op BenchmarkGetTaskDetail/Concurrent-6 5576 212538 ns/op 13847 B/op 328 allocs/op BenchmarkGetTaskDetail/Concurrent-6 5515 218339 ns/op 13843 B/op 328 allocs/op BenchmarkGetTaskDetail/Concurrent-6 5722 215569 ns/op 13845 B/op 328 allocs/op BenchmarkGetTaskDetail/Concurrent-6 5580 213162 ns/op 13843 B/op 328 allocs/op ```

claude[bot] (Migrated from github.com) reviewed

2026-02-23 20:40:47 -06:00

internal/testing/fixtures/db.go

					
				@ -52,6 +53,48 @@ func CaptureOutput(tb testing.TB, fn func()) string {

				// DefaultTestLabelColor is the default color used for test labels when the specific color doesn't matter.

PRAGMA synchronous = NORMAL is missing here. initSQLiteDB sets it in this same PR, so the benchmark DB diverges from the production configuration. For read-only benchmarks the omission does not affect timing, but the fixture should mirror production settings.

	if _, err := db.ExecContext(context.Background(), "PRAGMA synchronous = NORMAL"); err != nil {
		tb.Fatalf("Failed to set synchronous mode: %v", err)
	}
	if _, err := db.ExecContext(context.Background(), "PRAGMA busy_timeout = 5000"); err != nil {

`PRAGMA synchronous = NORMAL` is missing here. `initSQLiteDB` sets it in this same PR, so the benchmark DB diverges from the production configuration. For read-only benchmarks the omission does not affect timing, but the fixture should mirror production settings. ```suggestion if _, err := db.ExecContext(context.Background(), "PRAGMA synchronous = NORMAL"); err != nil { tb.Fatalf("Failed to set synchronous mode: %v", err) } if _, err := db.ExecContext(context.Background(), "PRAGMA busy_timeout = 5000"); err != nil { ```

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

noe.trevino/paso!134

				`@ -52,6 +53,48 @@ func CaptureOutput(tb testing.TB, fn func()) string {`
				`// DefaultTestLabelColor is the default color used for test labels when the specific color doesn't matter.`

Rows
Columns