fix: standup generator time zones #130

noe.trevino · 2026-02-23T11:40:45-06:00

noe.trevino commented

2026-02-23 11:40:45 -06:00

Checklist

Read CONTRIBUTING.md
Ran tests (go test ./... -race) locally
Formatted and linted with gofmt -w . and golangci-lint run ./... respectively
Added tests if necessary (significant changes/complex logic)
Updated documentation if applicable
Updated README.md if applicable

Summary

fixes an issue where logging wouldnt show in the generate.
Standup section of the application

## Checklist - [x] Read `CONTRIBUTING.md` - [x] Ran tests (`go test ./... -race`) locally - [x] Formatted and linted with `gofmt -w .` and `golangci-lint run ./...` respectively - [x] Added tests if necessary (significant changes/complex logic) - [x] Updated documentation if applicable - [x] Updated `README.md` if applicable ## Summary  fixes an issue where logging wouldnt show in the generate. Standup section of the application

claude[bot] (Migrated from github.com) reviewed

2026-02-23 11:46:34 -06:00

internal/database/adapters/sqlite/standup_log.go

					
				@ -9,0 +11,4 @@

				// uses internally when storing and comparing datetime values. Using this format for

				// query parameters ensures correct string comparison with values stored via

				// DEFAULT CURRENT_TIMESTAMP (which the driver also normalizes to this format on read).

				const sqliteDatetimeFormat = "2006-01-02T15:04:05Z"

The comment is self-contradictory and factually misleading. It says the driver uses this format "when storing and comparing datetime values", but the parenthetical immediately contradicts that: "which the driver also normalizes to this format on read". If normalization happens on read, the value is not stored in RFC3339.

DEFAULT CURRENT_TIMESTAMP in SQLite stores "YYYY-MM-DD HH:MM:SS" (no T, no Z). The constant is used as a query parameter format, not a storage format. The reason RFC3339 works is that SQLite's datetime() function (applied on both sides of the comparison) accepts multiple input formats including RFC3339, so it normalizes consistently. The comment should explain that, not claim the driver stores in this format.

The comment is self-contradictory and factually misleading. It says the driver uses this format "when **storing** and comparing datetime values", but the parenthetical immediately contradicts that: "which the driver also normalizes to this format **on read**". If normalization happens on read, the value is not stored in RFC3339. `DEFAULT CURRENT_TIMESTAMP` in SQLite stores `"YYYY-MM-DD HH:MM:SS"` (no `T`, no `Z`). The constant is used as a query *parameter* format, not a storage format. The reason RFC3339 works is that SQLite's `datetime()` function (applied on both sides of the comparison) accepts multiple input formats including RFC3339, so it normalizes consistently. The comment should explain that, not claim the driver stores in this format.

Sign in to join this conversation.

No reviewers