Bugfix 114/default in progress column #118

noe.trevino · 2026-02-21T18:48:30-06:00

noe.trevino commented

2026-02-21 18:48:30 -06:00

Checklist

Read CONTRIBUTING.md
Ran tests (go test ./... -race) locally
Formatted and linted with gofmt -w . and golangci-lint run ./... respectively
Added tests if necessary (significant changes/complex logic)
Updated documentation if applicable
Updated README.md if applicable

Summary

Fixes: #114

Sets the seeded inprogress column to the default inprogress column. used in cli flags. this is a special column.
Snapshot tests needed updating. here is the old to new:

Update test flakiness too

## Checklist - [x] Read `CONTRIBUTING.md` - [x] Ran tests (`go test ./... -race`) locally - [x] Formatted and linted with `gofmt -w .` and `golangci-lint run ./...` respectively - [x] Added tests if necessary (significant changes/complex logic) - [x] Updated documentation if applicable - [x] Updated `README.md` if applicable ## Summary  Fixes: #114 Sets the seeded inprogress column to the default inprogress column. used in cli flags. this is a special column. Snapshot tests needed updating. here is the old to new: <img width="931" height="712" alt="image" src="https://github.com/user-attachments/assets/e628430d-3458-4828-8bee-15104e9f11cd" /> Update test flakiness too

github-actions[bot] commented

2026-02-21 18:48:37 -06:00

(Migrated from github.com)

Informational Warning:

The snapshot tests have been changed.
Please add a screenshot showing what has been changed, and a description of why it was changed.

If you do not provide an explanation and screenshot in 3 days, this PR will be closed.

@TheNoeTrevino

Changed snapshot files (2 files)

internal/testing/snapshots/cli/testdata/e2e/column-list.golden
internal/testing/snapshots/cli/testdata/e2e/task-show.golden

**Informational Warning:** The snapshot tests have been changed. Please add a screenshot showing what has been changed, and a description of why it was changed. If you do not provide an explanation and screenshot in 3 days, this PR will be closed. @TheNoeTrevino <details> <summary>Changed snapshot files (2 files)</summary> - `internal/testing/snapshots/cli/testdata/e2e/column-list.golden` - `internal/testing/snapshots/cli/testdata/e2e/task-show.golden` </details>

👍 1

claude[bot] (Migrated from github.com) reviewed

2026-02-21 18:51:31 -06:00

internal/database/migrations.go

					
				@ -178,3 +178,4 @@

						HoldsInProgressTasks: true,

					})

					if err != nil {

						return fmt.Errorf("failed to create In Progress column: %w", err)

The second commit message says the fixture was corrected for "all three default columns (ready, in-progress, completed)", but CreateDefaultColumns here only adds HoldsInProgressTasks: true. The "Todo" and "Done" columns still have no flags set in production.

CreateTestProject now creates Todo with HoldsReadyTasks: true and Done with HoldsCompletedTasks: true, so tests run against a setup that users never actually get from CreateDefaultColumns. If paso task ready and paso task done require their column flags (the same enforcement that caused #114), those commands will still fail for any project created via the CLI.

Either:

Add HoldsReadyTasks: true to the Todo column and HoldsCompletedTasks: true to the Done column here to match the fixture, or
Document that those flags are not required for ready/done and revert the fixture's extra flag assignments for those two columns.

The second commit message says the fixture was corrected for "all three default columns (ready, in-progress, completed)", but `CreateDefaultColumns` here only adds `HoldsInProgressTasks: true`. The "Todo" and "Done" columns still have no flags set in production. `CreateTestProject` now creates Todo with `HoldsReadyTasks: true` and Done with `HoldsCompletedTasks: true`, so tests run against a setup that users never actually get from `CreateDefaultColumns`. If `paso task ready` and `paso task done` require their column flags (the same enforcement that caused #114), those commands will still fail for any project created via the CLI. Either: - Add `HoldsReadyTasks: true` to the Todo column and `HoldsCompletedTasks: true` to the Done column here to match the fixture, or - Document that those flags are not required for `ready`/`done` and revert the fixture's extra flag assignments for those two columns.

claude[bot] commented

2026-02-21 18:51:38 -06:00

(Migrated from github.com)

Review summary

One substantive issue: the production fix in migrations.go is incomplete relative to the test fixture update.

CreateDefaultColumns now correctly sets HoldsInProgressTasks: true for "In Progress", but the "Todo" and "Done" columns remain unflagged. At the same time, CreateTestProject in fixtures/db.go was updated to set all three flags (ready, in-progress, completed). This creates a divergence — tests run against a fully-flagged setup that the production function never produces. The column-list golden snapshot confirms the e2e test is driven by the fixture, not CreateDefaultColumns, so the snapshot change masks the gap rather than validating it.

If paso task ready and paso task done enforce their column flags the same way paso task in-progress does, those commands will fail for any project created via the CLI, reproducing the same class of bug as #114.

Score: 7/10

## Review summary One substantive issue: the production fix in `migrations.go` is incomplete relative to the test fixture update. `CreateDefaultColumns` now correctly sets `HoldsInProgressTasks: true` for "In Progress", but the "Todo" and "Done" columns remain unflagged. At the same time, `CreateTestProject` in `fixtures/db.go` was updated to set all three flags (ready, in-progress, completed). This creates a divergence — tests run against a fully-flagged setup that the production function never produces. The column-list golden snapshot confirms the e2e test is driven by the fixture, not `CreateDefaultColumns`, so the snapshot change masks the gap rather than validating it. If `paso task ready` and `paso task done` enforce their column flags the same way `paso task in-progress` does, those commands will fail for any project created via the CLI, reproducing the same class of bug as #114. **Score: 7/10**

Sign in to join this conversation.

No reviewers