Refactor ticket to task #128

Closed

AY88o wants to merge 3 commits from refactor-ticket-to-task into main

AY88o commented

2026-02-22 08:10:47 -06:00

(Migrated from github.com)

Checklist

[x ] Read CONTRIBUTING.md
[x ] Ran tests (go test ./... -race) locally
[x ] Formatted and linted with gofmt -w . and golangci-lint run ./... respectively
Added tests if necessary (significant changes/complex logic)
Updated documentation if applicable
Updated README.md if applicable

Summary

## Checklist - [x ] Read `CONTRIBUTING.md` - [x ] Ran tests (`go test ./... -race`) locally - [x ] Formatted and linted with `gofmt -w .` and `golangci-lint run ./...` respectively - [ ] Added tests if necessary (significant changes/complex logic) - [ ] Updated documentation if applicable - [ ] Updated `README.md` if applicable ## Summary

noe.trevino requested changes

2026-02-22 13:59:10 -06:00

internal/database/migrations_postgres/00001_initial_schema.sql

https://stackoverflow.com/questions/25398603/postgresql-query-to-rename-and-change-column-type-with-single-query
https://stackoverflow.com/questions/805363/how-do-i-rename-a-column-in-an-sqlite-database-table

let me know if you have any questions!
you can go ahead and fix this pr up to the first commit that you made.

The search a replace went too far here. SQL migrations are immutable, meaning they shouldnt be changed once they are ran. instead of changing the previous migrations, make a new one that renames the column. https://stackoverflow.com/questions/25398603/postgresql-query-to-rename-and-change-column-type-with-single-query https://stackoverflow.com/questions/805363/how-do-i-rename-a-column-in-an-sqlite-database-table let me know if you have any questions! you can go ahead and fix this pr up to the first commit that you made.

noe.trevino commented

2026-02-22 14:01:58 -06:00

Owner

@AY88o
Once you fix the requested change, I will approve the workflow. I left some articles if you are unfamiliar with database migrations.

Please add 'Closes: #128' to the description for automated workflow purposes. That will make github close the issue when the PR is merged.

The change is great! just a couple of correctness things.

Make sure to fill out the checklist as well.

@AY88o Once you fix the requested change, I will approve the workflow. I left some articles if you are unfamiliar with database migrations. Please add 'Closes: #128' to the description for automated workflow purposes. That will make github close the issue when the PR is merged. The change is great! just a couple of correctness things. Make sure to fill out the checklist as well.

noe.trevino reviewed

2026-02-22 14:03:16 -06:00

internal/database/migrations_postgres/00001_initial_schema.sql

https://nickcraver.com/blog/2016/05/03/stack-overflow-how-we-do-deployment-2016-edition/#database-migrations

AY88o commented

2026-02-22 14:13:51 -06:00

(Migrated from github.com)

Thanks for the review, Noe! I'm totally new to SQL migrations, so I'll need a few days to learn how this works before I update the PR. If you need this merged immediately or want to knock this one out yourself, feel free to take the issue back over! Otherwise, I'll get it fixed up later this week.

noe.trevino commented

2026-02-22 14:17:47 -06:00

Owner

@AY88o
I see that you are an undergrad in CS. SQL migrations are definitely something you should know! I'll keep this assigned to you, as it's a really good thing to learn.

If you have any questions, let me know. Basically all it is, instead of changing the previous migrations to match this change, write things in a way where you simply add a NEW migration that change the shape for you.

The reason it needs to never change (immutable) is that this migration will actually run every single time a database is created. Migrations are build on top of each other to move your initial database shape, to the one that you have migrated. Each addition is another migration to a new database shape.

This project also has "adapters". This lets the program connect to both SQLite, and PostgreSQL databases.

Again, if you have any questions, feel free to ask. Good luck!

@AY88o I see that you are an undergrad in CS. SQL migrations are definitely something you should know! I'll keep this assigned to you, as it's a really good thing to learn. If you have any questions, let me know. Basically all it is, instead of changing the previous migrations to match this change, write things in a way where you simply add a NEW migration that change the shape for you. The reason it needs to never change (immutable) is that this migration will actually run every single time a database is created. Migrations are build on top of each other to move your initial database shape, to the one that you have _migrated_. Each addition is another migration to a new database shape. This project also has "adapters". This lets the program connect to both SQLite, and PostgreSQL databases. Again, if you have any questions, feel free to ask. Good luck!