feat: add quickfix list integration #9
No reviewers
Labels
No labels
autorelease: pending
autorelease: tagged
bug
ci/cd
documentation
duplicate
enhancement
good first issue
help wanted
improvement
invalid
priority
high
priority
low
question
refactor
size
L
size
M
size
S
size
XS
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
noe.trevino/haunt.nvim!9
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/quickfix-integration"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR adds an optional quickfix list integration.
Motivation:
What’s included:
:HauntQuickfixcommand (with!for current-buffer only)Design notes:
As a non-snacks user this is a nice patch for me (I'd be happy with a Telescope integration either, but tbh, I never built such integration myself, but quickfix felt straightforward).
This is in the wrong place, but otherwise, a wonderful PR!
If you could also remove the todo in the readme, and update it with these changes so users know its available, i would appreciate it.
this module is specifically meant for the integration with the sidekick plugin from folke. I actually think that this specific function should go into the
storemodule. That module represent data persistence, and fetching (a database).Lets move this function over there
This one should go into the
apimodule, since it is more public facing. The name and all can stay the same.Nice!! That is freaking slick
Lets add a
vim.notify("haunt.nvim: no bookmarks found.", INFO)We don't want users to be confused in any way when using the plugin.
Soon, I am going to make a custom logger/notification config prop that users can toggle. For now, adding a
vim.notifyis pretty important IMOCool!
Okay so I’ve pushed updates:
@menisadi
Nice! I am going to approve this. I will be adding tests for this later today. I don't expect you to do that, but I will add you as a reviewer.
Thanks for the PR!
Thanks for the great plugin. Been using it already today and I like it alot.
I am glad you like it!
@menisadi I just realized, you said there was a helper for the quickfix, a user command. I don't see it. Were you wanting to add that as well? Just wanted to see if that was a mistake.
Oh you are right. There was in the first version. In the moving process I dropped it for some reason. It is not crucial I think. If someone wants a command they can bind the function easily.