smith: answer in review threads, resolve them after a check #4

Merged

noe.trevino merged 1 commit from smith-threads into main

2026-10-03 13:58:39 -05:00

noe.trevino commented

2026-10-03 13:58:39 -05:00

Owner

@smith in an inline review comment now gets its answer in that thread, not as a top-level comment.

After the push, a second, independent Claude pass checks each thread against the code and gives a confidence (0-100). At resolve-confidence (default 80) or more, smith resolves the thread. Below it, smith mentions the reviewer to check.

The API has no resolve call, so forge resolve signs in to the web page as smith (new secret SMITH_PASSWORD).

Tested on noe.trevino/smith-test#7: the JSDoc request was resolved (96%); the vague style request was left open with a mention (25%). Unit tests: 11 pass.

`@smith` in an inline review comment now gets its answer in that thread, not as a top-level comment. After the push, a second, independent Claude pass checks each thread against the code and gives a confidence (0-100). At `resolve-confidence` (default 80) or more, smith resolves the thread. Below it, smith mentions the reviewer to check. The API has no resolve call, so `forge resolve` signs in to the web page as smith (new secret `SMITH_PASSWORD`). Tested on noe.trevino/smith-test#7: the JSDoc request was resolved (96%); the vague style request was left open with a mention (25%). Unit tests: 11 pass.

noe.trevino added 1 commit

2026-10-03 13:58:39 -05:00

smith: answer in review threads; resolve them after an independent check

Smith tests / unit (push) Successful in 3s

Details

Smith tests / unit (pull_request) Successful in 4s

Details

233959c435

@smith in an inline review comment now gets its answer in that thread. After
the push, a verify pass rates each thread (0-100). At resolve-confidence
(default 80) smith resolves the thread through the web page (the API has no
resolve call; secret SMITH_PASSWORD); below it, smith mentions the reviewer.

forge: review-request --json, thread-reply, resolve.

noe.trevino merged commit 2f1c15d8c6 into main

2026-10-03 13:58:39 -05:00

noe.trevino deleted branch smith-threads

2026-10-03 13:58:40 -05:00

noe.trevino referenced this pull request from a commit

2026-10-03 13:58:40 -05:00

Merge pull request 'smith: answer in review threads, resolve them after a check' (#4) from smith-threads into main